ref(settings): convert OwnerInput from class to function component#110200
Merged
JoshuaKGoldberg merged 1 commit intomasterfrom Mar 10, 2026
Merged
ref(settings): convert OwnerInput from class to function component#110200JoshuaKGoldberg merged 1 commit intomasterfrom
JoshuaKGoldberg merged 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
TkDodo
approved these changes
Mar 10, 2026
Collaborator
TkDodo
left a comment
TkDodo
left a comment
There was a problem hiding this comment.
👍 gonna approve this upfront, left some mutation related comments that qualify as additional cleanup rather than the actual conversion
Comment on lines
66
to
67
| const api = new Client(); | ||
| const request = api.requestPromise( |
Collaborator
There was a problem hiding this comment.
can we convert this to using useMutation with fetchMutation as a fn. Example:
| }, | ||
| () => onSave?.(ownership) | ||
| ); | ||
| setHasChanges(false); |
Collaborator
There was a problem hiding this comment.
when we use a mutation, I feel like this becomes derived state by comparing the mutation data with the stored text:
const hasChanges = mutation.data !== text
Member
Author
|
💯 for sure! I've been hoping for an excuse to ramp up on mutations. Filed ENG-7011 Cleanup followups: OwnerInput switch from api.requestPromise to useMutation and assigned it to myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component had two areas of unused code:
mentionableUsers,mentionableTeams, andhandleAddRulewere never usedpathsandurlswere never used in its codeTested by going to /settings/projects/*/ownership/ and editing the ownership rules.